Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid email in a profile causes server error and doesn't add comment #21

Open
tirkarthi opened this issue Dec 1, 2018 · 1 comment
Open
Assignees

Comments

@tirkarthi
Copy link
Member

@tirkarthi tirkarthi commented Dec 1, 2018

When a user has an invalid email in their profile then while adding a comment in the issue to which they are subscribed tries to send an email to them. The invalid email causes failure which is not handled and I assumes it causes the transaction to rollback adding no comment to the issue but since other webhooks were triggered IRC is notified about the comment. Reporting this here in case someone stumbles upon this issue.

Relevant Zulip stream topic : https://python.zulipchat.com/#narrow/stream/116501-workflow/topic/Is.20adding.20comment.20in.20bpo.20broken.20for.20anyone.3F

cc: @ezio-melotti

@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Dec 1, 2018

I suspect this is a Roundup issue and should therefore be reported upstream, but I didn't have time to reproduce and investigate the issue yet.
We can keep this open as a reminder for now.

@berkerpeksag berkerpeksag self-assigned this Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.