perf: faster color parsing#9001
Merged
Merged
Conversation
Also know the rework parser shares the same known colors (faster, smaller bundle) There are some eslint fixes in there hope it is fine
NathanWalker
requested changes
Nov 4, 2020
| @@ -1,3 +1,5 @@ | |||
| import { getKnownColor } from "color/known-colors"; | |||
Contributor
There was a problem hiding this comment.
Thanks for this @farfromrefug - Let's make this relative import instead of barrel.
Collaborator
Author
There was a problem hiding this comment.
Sorry did not see that. Vscode did that ;)
NathanWalker
approved these changes
Nov 6, 2020
Contributor
NathanWalker
left a comment
There was a problem hiding this comment.
Excellent thank you 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also know the rework parser shares the same known colors (faster, smaller bundle)
There are some eslint fixes in there hope it is fine