Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add `exposed` property to hook context #1733

Open
wants to merge 1 commit into
base: master
from

Conversation

@vonagam
Copy link
Contributor

@vonagam vonagam commented Dec 10, 2019

The idea is that unless a context object is returned from the call hooks that modify context returning properties other than result (like statusCode and dispatch or other custom ones) may be skipped as those properties will not be used outside of hooks of the call itself.

Possible alternative names: dispatching or public.

@vonagam vonagam force-pushed the vonagam:feat-context-exposed-property branch from 19dfa17 to 9004de5 Dec 15, 2019
@daffl daffl closed this Jul 11, 2020
@vonagam
Copy link
Contributor Author

@vonagam vonagam commented Jul 11, 2020

Last one of those closings.
I will rebase it when asked.
Assuming that the proposition is accepted.

@daffl daffl reopened this Jul 11, 2020
@daffl
Copy link
Member

@daffl daffl commented Jul 11, 2020

Sounds good. Will definitely revisit this for the next version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.