Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with SVCB/HTTPS parsing of master file format #135

Merged
merged 1 commit into from Oct 10, 2020

Conversation

@adam-stoler
Copy link
Contributor

@adam-stoler adam-stoler commented Oct 9, 2020

Fix bug with parsing SVCB/HTTPS records from text where the Tokenizer is not properly reset at the end of the line. The individual record parsing works correctly, but this was breaking the parsing of master zone files with SVCB or HTTPS records in them.

…y reset at the end of parsing the record from text. Master format parsing requires this.

Added a unit test to verify the behavior
@ibauersachs ibauersachs added this to the v3.3.1 milestone Oct 10, 2020
@ibauersachs ibauersachs merged commit 1d0577c into dnsjava:master Oct 10, 2020
10 checks passed
10 checks passed
Java 8/x64/ubuntu-16.04 Java 8/x64/ubuntu-16.04
Details
Java 11/x64/ubuntu-16.04 Java 11/x64/ubuntu-16.04
Details
Java 8/x64/ubuntu-latest Java 8/x64/ubuntu-latest
Details
Java 11/x64/ubuntu-latest Java 11/x64/ubuntu-latest
Details
Java 8/x32/windows-latest Java 8/x32/windows-latest
Details
Java 8/x64/windows-latest Java 8/x64/windows-latest
Details
Java 11/x32/windows-latest Java 11/x32/windows-latest
Details
Java 11/x64/windows-latest Java 11/x64/windows-latest
Details
release
Details
coverage/coveralls Coverage increased (+0.09%) to 54.024%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.