Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools,src,test: bump cpplint to 1.5.0 #35719

Merged
merged 3 commits into from Oct 23, 2020
Merged

tools,src,test: bump cpplint to 1.5.0 #35719

merged 3 commits into from Oct 23, 2020

Conversation

@Trott
Copy link
Member

@Trott Trott commented Oct 20, 2020

Bump cpplint to 1.5.0 and refloat Node.js-specific patches.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott Trott force-pushed the Trott:cpplint-1.5.0 branch from ca2ef2c to 1d0fdcf Oct 20, 2020
@Trott Trott changed the title tools: bump cpplint to 1.5.0 tools,src,test: bump cpplint to 1.5.0 Oct 20, 2020
@aduh95
aduh95 approved these changes Oct 20, 2020
@Trott Trott force-pushed the Trott:cpplint-1.5.0 branch from 1d0fdcf to 63f9371 Oct 20, 2020
@Trott Trott added the request-ci label Oct 20, 2020
@github-actions github-actions bot removed the request-ci label Oct 20, 2020
@nodejs-github-bot

This comment has been hidden.

@Trott Trott force-pushed the Trott:cpplint-1.5.0 branch from 63f9371 to b3b776a Oct 20, 2020
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Oct 21, 2020

Trott added 3 commits Oct 20, 2020
PR-URL: #35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
https://github.com/cpplint/cpplint/releases/tag/1.5.0

PR-URL: #35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Cherry-pick 12c8b4d
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: #17373
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: 12c8b4d

Cherry-pick fc81e80
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: #21521
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: fc81e80

Cherry-pick cbc3dd9
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: #21010
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: cbc3dd9

Cherry-pick 9029981
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: #26306
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: 9029981

Cherry-pick 0a25ace
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: #27098
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: 0a25ace

Cherry-pick afa9a72
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: #30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: afa9a72

Cherry-pick e23bf8f
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: #31018
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

PR-URL: #35569
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott Trott force-pushed the Trott:cpplint-1.5.0 branch from b3b776a to d233f10 Oct 23, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Oct 23, 2020

Landed in 3f4ec9c...d233f10

@Trott Trott merged commit d233f10 into nodejs:master Oct 23, 2020
25 checks passed
25 checks passed
build-tarball
Details
build-tarball
Details
build-windows-with-quic build-windows-with-quic
Details
build-windows-with-quic build-windows-with-quic
Details
coverage-linux
Details
coverage-linux
Details
coverage-windows coverage-windows
Details
coverage-windows coverage-windows
Details
lint-addon-docs
Details
lint-addon-docs
Details
build-docs
Details
build-docs
Details
test-asan
Details
test-asan
Details
test-linux
Details
test-linux
Details
test-macOS-with-quic
Details
test-macOS-with-quic
Details
lint-cpp
Details
test-linux-with-quic
Details
lint-md
Details
lint-js
Details
lint-py
Details
lint-codeowners
Details
lint-codeowners
Details
@Trott Trott deleted the Trott:cpplint-1.5.0 branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.