Skip to content

/ sequelize

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ENGINE.md #12442

Merged
merged 1 commit into from Jun 30, 2020
Merged

Update ENGINE.md #12442

merged 1 commit into from Jun 30, 2020

Conversation

@haoxinst
Copy link
Contributor

@haoxinst haoxinst commented Jun 29, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?
@haoxinst
Update ENGINE.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e577bb6
@codecov
Copy link

@codecov codecov bot commented Jun 29, 2020 •
edited

Codecov Report

Merging #12442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12442   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          95       95           
  Lines        9192     9192           
=======================================
  Hits         8867     8867           
  Misses        325      325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0277bd6...e577bb6. Read the comment docs.
@sushantdhiman sushantdhiman merged commit b879eb1 into sequelize:master Jun 30, 2020
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 0277bd6...e577bb6
Details
codecov/project 96.46% (+0.00%) compared to 0277bd6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@haoxinst @sushantdhiman
You can’t perform that action at this time.