Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTypeshed maintainers: do you want to opt in to HacktoberFest? #4631
Comments
|
Sounds worth it to opt in, yes! Though reading those blog posts, I remember seeing an uptick in PRs on various repos that didn't seem like they'd fix anything useful. I wonder whether those were from Hacktoberfest participants. Anyway, we can deal with those PRs pretty easily. |
|
Digital Ocean's HacktoberFest is infamous for encouraging kids to spam
projects, but this year it seems they are (finally!) listening to
maintainers, and the rules to prevent spam have been tightened (I think if
maintainers mark a PR as spam that counts doubly against the contributor's
reputation or something).
For typeshed I think the reward will be higher than the risk.
|
|
While a bit cautious, I think we could give it a try. |
|
Okay, let’s do it. Can one of you do the honors? |
|
Done. I also added more topics (we had none yet). Let's leave this issue open until October is over, so we remember to remove the topic again. |
|
I pinned #4641 so that potential contributors can be a little bit more self sufficient when it comes to finding easy improvements to make. (As I mentioned in that issue, feel free to edit the text!) I think it's pretty savvy of us to make this change two weeks into October :-) |
Well, I had been watching the drama via a GitHub focus group for high-profile open source maintainers, and opened this issue once DigitalOcean announced they would make it opt-in and changed other rules to discourage spam. Thanks for the pinned issue! |
|
October is over and I have removed the label. Thanks for the suggestion! |
|
Did we get any good PRs? |
|
I don't recall any PRs that were labeled as being from hacktoberfest. |
|
Me neither, unfortunately. |
|
I opened a few PRs that were incentivized by Hacktoberfest, I have to say (also opened some on mypy even if it wasn't counting) So I'm encouraging you to keep doing this next year! |
|
I just discovered that removing the hacktoberfest topic makes digitalocean consider you opted out, so PRs don't count anymore. |
|
Sure, I re-added it for now. |
HacktoberFest changed to opt-in: https://hacktoberfest.digitalocean.com/hacktoberfest-update
Since contributing to typeshed is pretty simple, I expect the typical HF contributor to be more successful trying to contribute to typeshed than to e.g. mypy or cpython.