Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeshed maintainers: do you want to opt in to HacktoberFest? #4631

Closed
gvanrossum opened this issue Oct 7, 2020 · 14 comments
Closed

Typeshed maintainers: do you want to opt in to HacktoberFest? #4631

gvanrossum opened this issue Oct 7, 2020 · 14 comments
Assignees

Comments

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Oct 7, 2020

HacktoberFest changed to opt-in: https://hacktoberfest.digitalocean.com/hacktoberfest-update

Since contributing to typeshed is pretty simple, I expect the typical HF contributor to be more successful trying to contribute to typeshed than to e.g. mypy or cpython.

@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Oct 7, 2020

Sounds worth it to opt in, yes!

Though reading those blog posts, I remember seeing an uptick in PRs on various repos that didn't seem like they'd fix anything useful. I wonder whether those were from Hacktoberfest participants. Anyway, we can deal with those PRs pretty easily.

@gvanrossum
Copy link
Member Author

@gvanrossum gvanrossum commented Oct 7, 2020

@srittau
Copy link
Collaborator

@srittau srittau commented Oct 9, 2020

While a bit cautious, I think we could give it a try.

@gvanrossum
Copy link
Member Author

@gvanrossum gvanrossum commented Oct 9, 2020

Okay, let’s do it. Can one of you do the honors?

@srittau srittau self-assigned this Oct 9, 2020
@srittau
Copy link
Collaborator

@srittau srittau commented Oct 9, 2020

Done. I also added more topics (we had none yet). Let's leave this issue open until October is over, so we remember to remove the topic again.

@hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 10, 2020

I pinned #4641 so that potential contributors can be a little bit more self sufficient when it comes to finding easy improvements to make. (As I mentioned in that issue, feel free to edit the text!)

I think it's pretty savvy of us to make this change two weeks into October :-)

@gvanrossum
Copy link
Member Author

@gvanrossum gvanrossum commented Oct 10, 2020

I think it's pretty savvy of us to make this change two weeks into October :-)

Well, I had been watching the drama via a GitHub focus group for high-profile open source maintainers, and opened this issue once DigitalOcean announced they would make it opt-in and changed other rules to discourage spam.

Thanks for the pinned issue!

@srittau
Copy link
Collaborator

@srittau srittau commented Nov 1, 2020

October is over and I have removed the label. Thanks for the suggestion!

@srittau srittau closed this Nov 1, 2020
@gvanrossum
Copy link
Member Author

@gvanrossum gvanrossum commented Nov 1, 2020

Did we get any good PRs?

@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Nov 1, 2020

I don't recall any PRs that were labeled as being from hacktoberfest.

@srittau
Copy link
Collaborator

@srittau srittau commented Nov 1, 2020

Me neither, unfortunately.

@vbarbaresi
Copy link
Contributor

@vbarbaresi vbarbaresi commented Nov 2, 2020

I opened a few PRs that were incentivized by Hacktoberfest, I have to say (also opened some on mypy even if it wasn't counting)
Thanks hauntsaninja for the pinned issue about Good ways to contribute, that was really helpful.

So I'm encouraging you to keep doing this next year!

@vbarbaresi
Copy link
Contributor

@vbarbaresi vbarbaresi commented Nov 2, 2020

I just discovered that removing the hacktoberfest topic makes digitalocean consider you opted out, so PRs don't count anymore.
Would it be too much to ask that you keep the topic for ~2 weeks? There's a review period that lasts 14 days (even if the PR are already merged)

@srittau
Copy link
Collaborator

@srittau srittau commented Nov 2, 2020

Sure, I re-added it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.