Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: add debugger to the host hook to simplify the inspect #5
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). |
|
oh, it seems like I have requested this feature month ago... @devsnek hi |
| @@ -27,6 +27,7 @@ addEventListener('message', ({ data }) => { | |||
|
|
|||
| const agent = new Agent({ | |||
| features: [...state.get('features')], | |||
| onDebugger() { debugger }, // eslint-disable-line no-debugger | |||
devsnek
Oct 3, 2020
Member
Suggested change
onDebugger() { debugger }, // eslint-disable-line no-debugger
onDebugger() {
debugger; // eslint-disable-line no-debugger
},
Suggested change
| onDebugger() { debugger }, // eslint-disable-line no-debugger | |
| onDebugger() { | |
| debugger; // eslint-disable-line no-debugger | |
| }, |
|
Oh I have deleted forked repo in last few months so if I have to commit the change, I need to re-fork and open a new pr. Do you accept this without review resolved? Or I need to do it later |
|
pushed manually. |
|
Cool thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.