Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to Ruby 2.6.6 #987
Open
+19
−29
Conversation
|
|
|
I think this move should account for a couple other things too. |
Specs start failing with 2.7.1.
c915bbd
to
09f7cad
|
Ah yup, thanks for the reference commit @filipesperandio! PR is updated. |
|
Thanks! I also wouldn't mind if we update rubocop to a more recent version. (rubocop-0-92) |
d2485d9
to
7fa25be
|
Fixed the violations, upgraded Rubocop, and addressed the new violations as well. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Specs start failing with 2.7.1.