JS: Add model of Angular2 #4450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
reviewed
Oct 12, 2020
| import UnvalidatedDynamicMethodCallCustomizations::UnvalidatedDynamicMethodCall | ||
| private import DataFlow::FlowLabel | ||
|
|
||
| // Materialize flow labels |
Contributor
There was a problem hiding this comment.
You could add the below as a test somewhere:
import javascript
select any(DataFlow::FlowLabel label)That way we have a failing test if new flow-labels are added globally.
Also, this PR could use a merge.
And do you intend to rebase this PR on top of the recent ApiGraph changes?
Contributor
Author
There was a problem hiding this comment.
And do you intend to rebase this PR on top of the recent ApiGraph changes?
No, mentioned in the PR description, it took a lot of evaluations to get here, so I'll defer integration to a later PR.
erik-krogh
reviewed
Oct 16, 2020
javascript/ql/test/library-tests/FlowLabels/DefaulFlowLabels.ql
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I split the |
erik-krogh
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a model of Angular, also known as Angular2 (not to be confused with AngularJS; we already have a model of that).
The model relies heavily on type annotations, as Angular's dependency injection depends on type information (which seemed impossible until I read this blog post). This mean types aren't just a substitute for missing data flow in this model.
The model doesn't currently use API graphs as there isn't currently a drop-in replacement for
hasUnderlyingTypewhich is pretty important for this model. Some improvements for this exact use-case are underway, though given the number of evaluation I've had to run I'd prefer to postpone integration to a later PR.It also includes two commits to resolve some performance issues that arose since some more
Customizationsfiles are now transitively reachable fromjavascript.qll. In particular, we should avoid creating flow labels in such files as they affect all data flow configurations.Evaluations: (internal links)