Skip to content

/ html5lib-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLParser.lastPhase and beforeRCDataPhase are unused fields #515

Open
natebosch opened this issue Oct 14, 2020 · 0 comments
Open

HTMLParser.lastPhase and beforeRCDataPhase are unused fields #515

natebosch opened this issue Oct 14, 2020 · 0 comments

Comments

@natebosch
Copy link

@natebosch natebosch commented Oct 14, 2020

html5lib-python/html5lib/html5parser.py

Lines 166 to 168 in b2b08cc

self.lastPhase = None
self.beforeRCDataPhase = None

lastPhase used to be a useful field, it appears it was renamed to originalPhase in 43a2727

From what I can tell beforeRCDataPhase was something was either introduced unnecessarily or was partially removed during code review. The commit which introduces it does not assign an interesting value, and there are no reads. 566ca68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@natebosch
You can’t perform that action at this time.