support runtime in devDep#8888
Closed
farfromrefug wants to merge 1 commit into
Closed
Conversation
Right now it seems to be used for snapshot
rigor789
reviewed
Sep 24, 2020
| if (projectPackageJSON["nativescript"]) { | ||
| version = projectPackageJSON["nativescript"]["tns-android"]["version"]; | ||
| } else { | ||
| version = (projectPackageJSON["devDependencies"]["tns-android"] || projectPackageJSON["devDependencies"]["@nativescript/android"]).replace(/[~^]/, ''); |
Member
There was a problem hiding this comment.
The tricky part with this is that it could be a path to a tgz file too. The CLI tries to read from the installed runtimes package.json in node_modules if that's the case, but it's not "fool-proof".
I guess it's fine for now - just something we need to keep in mind.
Collaborator
Author
There was a problem hiding this comment.
You are right fdont like it either. Does not support latest or * too....
d4ced42 to
53488b5
Compare
Contributor
|
Closing as confirmed operational and not pursuing snapshots. |
Collaborator
Author
|
Again total nonsense... Either remove all the snapshot code now or accept fixes |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it seems to be used for snapshot
This is one part of more global fix for snapshots which are broken with latest webpack