Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck node.js version same as in default variant #1069
Conversation
Verify that node.js version for each variant as it is for default variant for each node.js major version.
|
What happened in #1063 is that I merged the Buster PR and forgot to request a rebase. I'm not sure we need this restriction. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tvainika commentedJul 25, 2019
Verify that node.js version for each variant as it is for default variant for each node.js major version.
This prevents accidents such as #1063 where only some variant images were updated to newer Node.js version.
The test is skipped with onbuild variant, because it specifies the version differently, and ongoing variant is deprecated.