Skip to content

/ xls

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer assertion failures for signed numbers #86

Open
cdleary opened this issue Aug 12, 2020 · 1 comment
Open

Nicer assertion failures for signed numbers #86

cdleary opened this issue Aug 12, 2020 · 1 comment
Assignees
@cdleary
Labels
dslx good first issue

Comments

@cdleary
Copy link
Collaborator

@cdleary cdleary commented Aug 12, 2020

Right now we don't take into account that the type being checked in the assertion is signed.

* 0119:   let _ = assert_eq(s11:-293, extract_coeff(u9:0xda ++ u2:0, u4:9));
        ~~~~~~~~~~~~~~~~~~~^----------------------------------------------^ The program being interpreted failed! 
  want: 1755
  got:  1
@cdleary cdleary added the dslx label Aug 12, 2020
@cdleary cdleary self-assigned this Aug 12, 2020
@cdleary
Copy link
Collaborator Author

@cdleary cdleary commented Aug 12, 2020

The type should also be used to pretty-print enum values in assertion failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdleary cdleary

Labels
dslx good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@cdleary
You can’t perform that action at this time.