Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression due to width_aware_slice #717

Closed
yangle opened this issue Nov 10, 2017 · 2 comments
Closed

Performance regression due to width_aware_slice #717

yangle opened this issue Nov 10, 2017 · 2 comments

Comments

@yangle
Copy link

@yangle yangle commented Nov 10, 2017

Apparently ef91741 introduced a significant performance regression when printing a long output. (The precise commit was pinned down through git bisect.)

To reproduce it, run

$ bpython
bpython version 0.18.dev15 on top of Python 2.7.13 /tmp/bpython/.venv/bin/python2
>>> ' '.join(map(str, xrange(10000)))
(hangs)

After reverting ef91741, printing ' '.join(map(str, xrange(10000))) takes less than a blink.

@yangle
Copy link
Author

@yangle yangle commented Nov 10, 2017

Just realized that this is a duplicate of #703.

@sebastinas
Copy link
Contributor

@sebastinas sebastinas commented Nov 18, 2017

Let's continue that in #703.

@sebastinas sebastinas closed this Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.