Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPaste detection in bpython instead of Curtsies, fixes #575 #584
Conversation
|
Sure |
|
Great I'll merge it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
thomasballinger commentedDec 6, 2015
This switches from using curtsies-created paste events to creating paste events in bpython whenever 10 or more keypress events are queued up.
I think long term this is a good move because it's one less Curtsies-specific piece of input functionality, and I'd like to remove this feature from Curtsies and use Blessed for input code eventually because I trust @jquast to get it right more than I do myself. It's also better because now it helps the UI catch up any time it gets behind on events, e.g. from a fast typist on a slow machine, whereas before the bytes had to be read in the same system call to be considered a paste event. The paste threshold of 10 should be tuned for this, it should probably be much lower (2 or 3?).
If you don't like the
combined_eventscoroutine I'd be happy to reimplement it as a class, I think that might be clearer but because the.sendandnext()interface was all we needed it seemed easy to write that way.