Skip to content

/ bpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a look at getattr_static #163

Open
ikanobori opened this issue Jul 4, 2014 · 3 comments
Open

Have a look at getattr_static #163

ikanobori opened this issue Jul 4, 2014 · 3 comments
Labels
enhancement

Comments

@ikanobori
Copy link
Contributor

@ikanobori ikanobori commented Jul 4, 2014

We should probably use it instead of our AttrCleaner madness.

See http://bugs.python.org/issue9732 and http://www.voidspace.org.uk/python/weblog/arch_d7_2010_11_20.shtml#e1194
@ikanobori
Copy link
Contributor Author

@ikanobori ikanobori commented Jul 4, 2014

See also http://bugs.python.org/issue11770

Original Comment By: Andreas Stührk
@ikanobori
Copy link
Contributor Author

@ikanobori ikanobori commented Jul 4, 2014

Yep, definitely looks good. Full support from me for trying this out. If it passes our amazing test coverage then we should be good. :)

Original Comment By:

@rybarczykj rybarczykj mentioned this issue Jul 30, 2020
Merged
@rybarczykj
Copy link
Contributor

@rybarczykj rybarczykj commented Aug 20, 2020

Implemented with PR #832 . And you're exactly right, once Python2 support is dropped (soon), AttrCleaner can be removed (or greatly reduced).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ikanobori @rybarczykj
You can’t perform that action at this time.