Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run PR cleanup in parallel with force #850

Merged
merged 1 commit into from Aug 13, 2020

Conversation

@nschonni
Copy link
Member

nschonni commented Aug 13, 2020

Force to avoid failed build for non-previewed PRs

Description

Should speedup the cleanup by running in parallel, and avoid false failures for PRs closed with no previews

Related Issues

Force to avoid failed build for non-previewed PRs
@nschonni nschonni requested a review from MylesBorins Aug 13, 2020
@nschonni
Copy link
Member Author

nschonni commented Aug 13, 2020

/preview

@github-actions
Copy link

github-actions bot commented Aug 13, 2020

Please find a preview at: https://staging.nodejs.dev/850/

Copy link
Member

MylesBorins left a comment

LGTM

@MylesBorins MylesBorins merged commit 1908207 into master Aug 13, 2020
2 checks passed
2 checks passed
test-ci
Details
test-ci
Details
@nschonni nschonni deleted the nschonni-parallel-cleanup branch Aug 13, 2020
@nschonni
Copy link
Member Author

nschonni commented Aug 13, 2020

Looks like it did speed it up quite a bit

@MylesBorins
Copy link
Member

MylesBorins commented Aug 13, 2020

it was averaging 4 objects a second before running in parallel... with 519 objects that was just over 2 minutes... down to 20 seconds!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.