Skip to content

/ nodejs.dev

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for ENVIROMENT #828

Open
wants to merge 2 commits into
base: master
from
Open

Remove check for ENVIROMENT #828

wants to merge 2 commits into from

Conversation

@JasonEtco
Copy link
Member

JasonEtco commented Aug 11, 2020

Description

👋 This removes the check for process.env.ENVIROMENT from gatsby-config.js. It currently has two problems:

  • I think this was intended to be NODE_ENV, the standard value for Node's environment setting.
  • dotenv doesn't need to be gated like this; if .env doesn't exist, it'll be a noop. This is fairly common practice, and avoids that extra check and eslint-disable comment.

Related Issues

N/A
@JasonEtco
Remove check for ENVIROMENT
Loading status checks…
9d54cf2
@benhalverson
benhalverson approved these changes Aug 11, 2020
View changes
@designMoreWeb
designMoreWeb approved these changes Aug 11, 2020
View changes
@benhalverson
Merge branch 'master' into remove-dotenv-env-check
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
29ea6e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designMoreWeb designMoreWeb

@benhalverson benhalverson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@JasonEtco @designMoreWeb @benhalverson
You can’t perform that action at this time.