Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add windows CI to Improve stability #771

Closed
gengjiawen opened this issue Jul 18, 2020 · 2 comments
Closed

add windows CI to Improve stability #771

gengjiawen opened this issue Jul 18, 2020 · 2 comments
Labels
stale

Comments

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jul 18, 2020

Currently windows build is break due to 3.0.1 release.

This is also caught by our daily CI in node-addon-examples (I got the failed email notification everyday 4 days ago, I guess a good thing).

I think add related CI for this repo like we did in node-addon-examples. Any thought ?
@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jul 20, 2020

We do have testing her, but we obviously don't have a test that catches the problematic case: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/

So first thing is to make sure we add some test cases that cover the different include use cases (spaces, multiple etc.)

@github-actions
Copy link

@github-actions github-actions bot commented Dec 15, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Dec 15, 2020
@github-actions github-actions bot closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gengjiawen @mhdawson