Skip to content

/ github-bot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub bot commenting on wrong repository if different than nodejs/node #262

Open
mmarchini opened this issue Jun 27, 2020 · 2 comments
Open

GitHub bot commenting on wrong repository if different than nodejs/node #262

mmarchini opened this issue Jun 27, 2020 · 2 comments

Comments

@mmarchini
Copy link
Member

@mmarchini mmarchini commented Jun 27, 2020

Started a Jenkins CI for nodejs/node-auto-test#19, the bot commented on nodejs/node#19 (comment).
@richardlau
Copy link
Member

@richardlau richardlau commented Jun 27, 2020

This is (mainly) a build issue. See nodejs/build#2166 (comment). It will involve updating every node-test-commit-* job to pass the REPO parameter through to the pipeline that triggers the bot.

(As an aside, I think the bot is hardcoded to use the nodejs org:

github-bot/scripts/jenkins-status.js

Line 46 in b5904f9

owner: 'nodejs',
)
@mmarchini
Copy link
Member Author

@mmarchini mmarchini commented Jun 27, 2020

The bot expects the repo parameter, so we should probably do it (although for the comment maybe only node-test-pull-request needs updating?). There's no easy way to update those jobs, right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@mmarchini @richardlau
You can’t perform that action at this time.