Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: Make documentation button hit area the whole button in Shell box #809
Conversation
|
/preview |
github-actions
bot
commented
Aug 10, 2020
|
Please find a preview at: https://staging.nodejs.dev/809/ |
designMoreWeb
commented
Aug 10, 2020
|
Thanks for the contribution this looks good to me |
|
Semantically, wouldn't a button be More Correct HTML? Definitely not opposed to making the button area bigger, but ideally we'd be using semantically correct HTML |
I think a button makes more sense if it was performing an action on the page or navigating internally. Since this opens an external link, it should be treated as a link. I'm using this as a reference. As a sanity check, I checked the landmarks/navigation with a screen reader and it sounds alright. |
|
@JohnPhamous fair enough. fwiw eventually this should open the internal link to a docs implementation rather than the external existing docs site. |
JohnPhamous commentedAug 10, 2020
•
edited
Description
No visual changes were made. The "Read documentation" button was a
buttonwith anainside. This reduces the hit area of the button that results in an action (opening the documentation) only the text bounds.The fix is to apply the button styles directly to the
a. This PR also makes keyboard/AT navigation a lot better, an accessibility win!This PR also updates the button's styles to match the mockup in Figma.
Related Issues