Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar fix in tutorial #18425

Merged
merged 1 commit into from Feb 10, 2020
Merged

Grammar fix in tutorial #18425

merged 1 commit into from Feb 10, 2020

Conversation

donkirkby
Copy link
Contributor

@donkirkby donkirkby commented Feb 9, 2020 •
edited by miss-islington

Thanks for publishing this tutorial. Here's a small grammar fix.

Automerge-Triggered-By: @csabella

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Feb 9, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@donkirkby

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 9, 2020
csabella
csabella approved these changes Feb 9, 2020
View changes
Copy link
Contributor

@csabella csabella left a comment

LGTM. Thank you for submitting this change, @donkirkby!

@csabella csabella added needs backport to 3.8 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news and removed CLA not signed labels Feb 9, 2020
@csabella csabella merged commit 3ed4d25 into python:master Feb 10, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

Thanks @donkirkby for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
@donkirkby @miss-islington
Grammar fix in tutorial (pythonGH-18425)
d680d2a 
(cherry picked from commit 3ed4d25)

Co-authored-by: Don Kirkby <donkirkby@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 10, 2020

GH-18426 is a backport of this pull request to the 3.8 branch.

csabella pushed a commit that referenced this pull request Feb 10, 2020
@miss-islington @donkirkby
Grammar fix in tutorial (GH-18425) (GH-18426)
b086ea5 
(cherry picked from commit 3ed4d25)

Co-authored-by: Don Kirkby <donkirkby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@donkirkby @the-knights-who-say-ni @miss-islington @bedevere-bot @csabella