Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up1762780: fix bug, when reporter_id is empty; ENT-1706 #247
Conversation
|
It needs more testing, because I changed validation method. |
virtwho/config.py
Outdated
| result = ('warning', '%s is not set to a valid string, using default: %s' % | ||
| (key, self.defaults[key])) | ||
| else: | ||
| result = ('warning', '%s is not set to a valid string and has default value: %s' % key) |
wottop
Jan 13, 2020
Member
has no default value?
has no default value?
jirihnidek
Jan 14, 2020
Author
Collaborator
Good point. Thanks.
Good point. Thanks.
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1762780 * Validation using _validate_non_empty_string did not have side effect of setting default value and debug print also didn't print default value * Added two unit tests for _validate_non_empty_string method
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
effect of setting default value and debug print also didn't
print default value