Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/code-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix for the Dockerfile and build #188

Merged
merged 2 commits into from Mar 11, 2019
+9 −4

Conversation

Reviewers

@avelino avelino

@kylecarbs kylecarbs

@code-asher code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nhooyr @avelino @kylecarbs
@nhooyr
Copy link
Collaborator

nhooyr commented Mar 10, 2019

No description provided.

@nhooyr
Dockerfile: fix 
ENTRYPOINT must be provided in exec form for args
from docker run to be passed correctly.

See https://docs.docker.com/engine/reference/builder/#cmd
Verified
This commit was signed with a verified signature.
@nhooyr nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
3bf3108

@nhooyr nhooyr requested review from code-asher and kylecarbs as code owners Mar 10, 2019

@nhooyr
build: fix reuse of vscode repository regression 
See #167
Verified
This commit was signed with a verified signature.
@nhooyr nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
Loading status checks…
674242f

@nhooyr nhooyr force-pushed the anmol branch from a863d1c to 674242f Mar 10, 2019

@avelino

avelino approved these changes Mar 10, 2019
View changes

Copy link
Contributor

avelino left a comment

LGTM

@nhooyr nhooyr referenced this pull request Mar 11, 2019

Open

sudo in Dockerfile? #65

@kylecarbs kylecarbs merged commit 03c0bde into master Mar 11, 2019

@kylecarbs kylecarbs deleted the anmol branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.