bpo-35471: Remove the macpath module #11129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2.4 dropped MacOS 9 support. The macpath module was deprecated in Python 3.7. This change removes it.
serhiy-storchaka
reviewed
Dec 12, 2018
| </Project> |
There was a problem hiding this comment.
It seems like my text editor (vim) likes to add newline. Well, this change shouldn't hurt :-)
| @@ -124,7 +124,7 @@ def main(): | |||
|
|
|||
| # default the exclude list for each platform | |||
| if win: exclude = exclude + [ | |||
| 'dos', 'dospath', 'mac', 'macpath', 'macfs', 'MACFS', 'posix', ] | |||
There was a problem hiding this comment.
'dospath'? Seriously?
There was a problem hiding this comment.
I don't know any of these modules (except of "posix"), so I chose to not touch this old code...
|
@serhiy-storchaka: I made two changes, see my second commit. |
|
@ronaldoussoren wrote "I'm in favour of removing macpath.": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.
https://bugs.python.org/issue35471