Conversation
…ng attribute patching fix: #11177
Size ReportBundles
Usages
|
Member
Author
|
I think this patch is worthwhile, but I want to mention that this is an edge case for specific web component implementations, and the |
This was referenced Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers an edge case where a web component actually overrides
el.setAttributeand thus is able to receive non-string values as attribute values (appareantly, extJS web components do this).This patch ensures that we leave stringification to the browser when patching an element attribute except for the case of symbols, where we need to explicitly stringify it ourselves as the browser would throw an error.
fix: #11177