perf(ssr): do a single-pass over AST with node cache arrays#17812
Merged
bluwy merged 3 commits intovitejs:mainfrom Aug 3, 2024
Merged
perf(ssr): do a single-pass over AST with node cache arrays#17812bluwy merged 3 commits intovitejs:mainfrom
bluwy merged 3 commits intovitejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have noticed in the Nuxt dev server flamegraph with the Node inspector that quite some time is spent on
ssrTransformScript. Looked for areas where time can be reduced and noticed that it's not necessary to do multiple passes over the entire AST. This could be a win for larger files, by isolating the import/export decls once and deallocating the 2 cache arrays while processing them to only temporarily create the references.