Skip to content

feat(eslint-plugin): [ban-types] add NonNullable suggestion and allow custom suggestions - #6876

Merged
JoshuaKGoldberg merged 2 commits into
typescript-eslint:mainfrom
NotWoods:ban-types-update
Apr 16, 2023
Merged

feat(eslint-plugin): [ban-types] add NonNullable suggestion and allow custom suggestions#6876
JoshuaKGoldberg merged 2 commits into
typescript-eslint:mainfrom
NotWoods:ban-types-update

Conversation

@NotWoods

@NotWoods NotWoods commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

This PR adds NonNullable<unknown> to the list of alternatives for Object and {}, and introduces suggestions to automatically replace those types with NonNullable<unknown>.

@typescript-eslint

typescript-eslint Bot commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR, @NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Apr 9, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e9fcabd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64333f66b2056a00087e18b2
😎 Deploy Preview https://deploy-preview-6876--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NotWoods NotWoods changed the title Update ban-types error message feat(ban-types): add NonNullable suggestion and allow custom suggestions Apr 9, 2023
@NotWoods NotWoods changed the title feat(ban-types): add NonNullable suggestion and allow custom suggestions feat(eslint-plugin): [ban-types] add NonNullable suggestion and allow custom suggestions Apr 9, 2023
@nx-cloud

nx-cloud Bot commented Apr 9, 2023 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e9fcabd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@codecov

codecov Bot commented Apr 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6876 (e9fcabd) into main (f0f83ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6876   +/-   ##
=======================================
  Coverage   87.36%   87.37%           
=======================================
  Files         386      386           
  Lines       13190    13193    +3     
  Branches     3867     3868    +1     
=======================================
+ Hits        11524    11527    +3     
  Misses       1300     1300           
  Partials      366      366
Flag Coverage Δ
unittest 87.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Apr 10, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 16, 2023
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 looks great, thanks @NotWoods!

'yay' balloon with confetti

@JoshuaKGoldberg
JoshuaKGoldberg merged commit ff65235 into typescript-eslint:main Apr 16, 2023
@NotWoods
NotWoods deleted the ban-types-update branch April 16, 2023 19:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

enhancement: plugin rule option New rule option for an existing eslint-plugin rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [ban-types] Add suggest option to types Enhancement: [ban-types] Suggest NonNullable<unknown> as an alternative for {} and Object

3 participants

@NotWoods @JoshuaKGoldberg @bradzacher