Skip to content

next release v4.62.3#1246

Merged
casperdcl merged 15 commits intomasterfrom
devel
Sep 20, 2021
Merged

next release v4.62.3#1246
casperdcl merged 15 commits intomasterfrom
devel

Conversation

@casperdcl
Copy link
Copy Markdown
Member

@casperdcl casperdcl commented Sep 9, 2021 •
edited
Loading

  • fix minor typo
  • minor example fix
  • misc tidying & refactoring
  • misc build & test framework updates
    • update dependencies
    • update linters
    • update docs deployment branches
    • test forks
    • tidy OS & Python version tests
    • bump primary python version 3.7 => 3.8

@casperdcl casperdcl self-assigned this Sep 9, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2021 •
edited
Loading

Codecov Report

Merging #1246 (058fe72) into master (140c948) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   89.68%   89.67%   -0.02%     
==========================================
  Files          26       26              
  Lines        1735     1733       -2     
  Branches      287      286       -1     
==========================================
- Hits         1556     1554       -2     
  Misses        133      133              
  Partials       46       46

@casperdcl casperdcl requested a review from a team as a code owner September 18, 2021 11:52
@casperdcl casperdcl mentioned this pull request Sep 18, 2021
Closed
@casperdcl casperdcl force-pushed the devel branch 2 times, most recently from c3276bc to 4d5ca0b Compare September 18, 2021 12:52
@casperdcl casperdcl force-pushed the devel branch 7 times, most recently from 4382f89 to c65ff8d Compare September 18, 2021 13:59
@casperdcl casperdcl force-pushed the devel branch 12 times, most recently from 6f0e461 to ddc362d Compare September 18, 2021 20:36
@casperdcl casperdcl added the c8-hard 🕗 Complexity high label Sep 19, 2021
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Sep 19, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.18%.

Quality metrics Before After Change
Complexity 11.54 🙂 11.36 🙂 -0.18 👍
Method Length 72.99 🙂 72.84 🙂 -0.15 👍
Working memory 10.18 😞 10.14 😞 -0.04 👍
Quality 60.71% 🙂 60.89% 🙂 0.18% 👍
Other metrics Before After Change
Lines 4287 4238 -49
Changed files Quality Before Quality After Quality Change
.meta/mkdocs.py 58.46% 🙂 58.46% 🙂 0.00%
examples/7zx.py 27.55% 😞 27.52% 😞 -0.03% 👎
tests/tests_contrib.py 75.21% ⭐ 76.14% ⭐ 0.93% 👍
tests/tests_itertools.py 92.92% ⭐ 92.92% ⭐ 0.00%
tests/tests_perf.py 63.52% 🙂 64.30% 🙂 0.78% 👍
tests/tests_tqdm.py 67.21% 🙂 67.29% 🙂 0.08% 👍
tqdm/_monitor.py 75.55% ⭐ 75.55% ⭐ 0.00%
tqdm/_utils.py 79.09% ⭐ 79.09% ⭐ 0.00%
tqdm/rich.py 79.38% ⭐ 79.38% ⭐ 0.00%
tqdm/std.py 47.10% 😞 47.27% 😞 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tqdm/std.py tqdm.format_meter 73 ⛔ 572 ⛔ 29 ⛔ 2.09% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py tqdm.__init__ 53 ⛔ 553 ⛔ 39 ⛔ 3.16% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py tqdm.pandas 53 ⛔ 409 ⛔ 13 😞 15.07% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
examples/7zx.py main 38 ⛔ 379 ⛔ 15 😞 16.33% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/tests_perf.py simple_progress 34 ⛔ 298 ⛔ 17 ⛔ 17.63% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@casperdcl
Copy link
Copy Markdown
Member Author

casperdcl commented Sep 19, 2021

failing deploy due to https://github.com/snapcore/action-build/issues/25

@casperdcl casperdcl merged commit 18d7aa4 into master Sep 20, 2021
@casperdcl
Copy link
Copy Markdown
Member Author

casperdcl commented Sep 20, 2021

/tag v4.62.3 18d7aa4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@casperdcl casperdcl

Labels

c8-hard 🕗 Complexity high p3-framework ⚒ CI/CD to-merge ↰ Imminent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@casperdcl