Configuration sample in reference doc has wrong yaml formatting#28671
Closed
weixsun wants to merge 1 commit intospring-projects:mainfrom
Closed
Configuration sample in reference doc has wrong yaml formatting#28671weixsun wants to merge 1 commit intospring-projects:mainfrom
weixsun wants to merge 1 commit intospring-projects:mainfrom
Conversation
snicoll
reviewed
Nov 14, 2021
Member
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR, I've left a couple comments.
| - USER | ||
| - ADMIN | ||
| service: | ||
| remote-address: "192.168.1.1" |
Member
There was a problem hiding this comment.
This PR is doing two different things here. Are the quote around the value necessary?
Contributor
Author
There was a problem hiding this comment.
Ha, I think the String type here is more suitable, so I just did it.
| service: | ||
| remote-address: "192.168.1.1" | ||
| security: | ||
| username: "admin" |
snicoll
pushed a commit
that referenced
this pull request
Nov 16, 2021
snicoll
added a commit
that referenced
this pull request
Nov 16, 2021
Member
|
Thanks again @weixsun. I have reverted the quote change as discussed (not necessary and inconsistent with other configuration samples). |
Member
|
I think we should probably quote Strings in YAML. I tried to add a review note but I didn't click "submit" 🤦. I've opened #28709. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is just a modification of the code style of the yaml code block.