Azure App Service is not correctly detected on Windows#27819
Closed
jdubois wants to merge 3 commits intospring-projects:mainfrom
Closed
Azure App Service is not correctly detected on Windows#27819jdubois wants to merge 3 commits intospring-projects:mainfrom
jdubois wants to merge 3 commits intospring-projects:mainfrom
Conversation
Contributor
Author
|
Forcing a new build as the CI failed, but the error message seems to be about a failing "git pull" |
Member
|
@jdubois there's no need to force a new CI build. |
Contributor
Author
|
Sorry @snicoll I don't know how Concourse works! Just found the issue and fixed it. |
Contributor
Author
|
If you ever want to move to GitHub Actions please ping me (that's Microsoft and the runners are on Azure!) |
Member
|
Going forward, please build locally before submitting the PR. The formatting errors are checked by the build, not CI. |
Contributor
Author
|
Yes sorry, I just ran the test locally, last time I did a build it took like 2 hours on my Mac |
Member
|
This PR only touches files on the |
snicoll
pushed a commit
that referenced
this pull request
Sep 6, 2021
snicoll
added a commit
that referenced
this pull request
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the discussion in #27657 - but I used 4 variables instead of 3, to reduce the risk even more!