Remote devtools endpoint cannot be accessed if actuator and spring security are on the classpath #25868
Closed
hatefpalizgar wants to merge 2 commits intospring-projects:mainfrom
Closed
Remote devtools endpoint cannot be accessed if actuator and spring security are on the classpath #25868hatefpalizgar wants to merge 2 commits intospring-projects:mainfrom
hatefpalizgar wants to merge 2 commits intospring-projects:mainfrom
Conversation
…d spring security are on the classpath
Member
|
Thanks for the PR, @hatefpalizgar. Before we can merge this change, we'll need to add a test that verifies that it has fixed the problem. Would you be interested in doing that? |
Contributor
Author
|
Sure. I will do it. |
47fee17 to
f884e34
Compare
philwebb
pushed a commit
that referenced
this pull request
May 18, 2021
Update `ManagementWebSecurityAutoConfiguration` so that the `managementSecurityFilterChain` bean has an explicit order. Prior to this commit, the `managementSecurityFilterChain` would override the `securityFilterChain` in `RemoteDevtoolsSecurityConfiguration` which would prevent the remote devtools endpoint from being accessed. See gh-25868
philwebb
added a commit
that referenced
this pull request
May 18, 2021
Member
|
Thanks for the PR @hatefpalizgar. I've merged this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bug #25350 in which remote devtools endpoint cannot be accessed if actuator and spring security are on the classpath. The reason is the lack of explicit ordering for
managementSecurityFilterChainwhich leads to overwritingRemoteDevtoolsSecurityfilter chain.