Skip to content

Fix #967 Attach AppConfig#getSingleTeamToken() to App#client()#970

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-967-app-client
Apr 14, 2022
Merged

Fix #967 Attach AppConfig#getSingleTeamToken() to App#client()#970
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-967-app-client

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Apr 14, 2022

This pull request resolves #967

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt labels Apr 14, 2022
@seratch seratch added this to the 1.21.2 milestone Apr 14, 2022
@seratch seratch self-assigned this Apr 14, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2022

Codecov Report

Merging #970 (b3edbca) into main (890d794) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #970      +/-   ##
============================================
+ Coverage     76.99%   77.02%   +0.02%     
- Complexity     3676     3678       +2     
============================================
  Files           397      397              
  Lines         11066    11067       +1     
  Branches       1099     1099              
============================================
+ Hits           8520     8524       +4     
+ Misses         1880     1879       -1     
+ Partials        666      664       -2
Impacted Files Coverage Δ
bolt/src/main/java/com/slack/api/bolt/App.java 69.19% <100.00%> (+0.05%) ⬆️
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 84.84% <0.00%> (+0.43%) ⬆️
...va/com/slack/api/socket_mode/SocketModeClient.java 68.15% <0.00%> (+0.63%) ⬆️
...i/socket_mode/impl/SocketModeClientJavaWSImpl.java 66.44% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890d794...b3edbca. Read the comment docs.

@seratch seratch merged commit bf977d8 into slackapi:main Apr 14, 2022
@seratch seratch deleted the issue-967-app-client branch April 14, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality project:bolt

Projects

None yet

Milestone

1.21.2

Development

Successfully merging this pull request may close these issues.

Attach AppConfig#getSingleTeamToken() to App#client()

1 participant

@seratch