Merged
Conversation
dtolnay
reviewed
Apr 25, 2024
Member
dtolnay
left a comment
There was a problem hiding this comment.
Cargo features are required to be additive, so enabling a feature cannot result in an impl being removed.
Contributor
Author
|
Now that I think about it, since the type of key is fixed to |
Hash for Value when "preserve_order" feature is not setHash for Value
dtolnay
approved these changes
Jun 25, 2024
Member
dtolnay
left a comment
There was a problem hiding this comment.
Thanks!
For the cfg(feature = "preserve_order") case, maybe a better performing implementation would be to hash each entry individually and xor them together. This would make the hash insensitive to order.
use std::hash::{BuildHasher, RandomState};
use std::sync::OnceLock;
static RANDOM_STATE: OnceLock<RandomState> = OnceLock::new();
let random_state = RANDOM_STATE.get_or_init(RandomState::new);
self.map
.iter()
.map(|entry| random_state.hash_one(entry))
.fold(0, |xor, next| xor ^ next)
.hash(state);I would be interested to see a benchmark comparing this approach.
takumi-earth
pushed a commit
to earthlings-dev/json
that referenced
this pull request
Jan 27, 2026
impl `Hash` for `Value`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexMapis the only type that is used withinValuethat does not implementHash, and it is by design: indexmap-rs/indexmap#288 (comment)If "preserve_order" feature is not set,
Value::ObjectusesBTreeMapinstead ofIndexMapso it is possible to auto-implHashforValue.