Skip to content

Allow trailing backslash in string interpolators#8942

Merged
lrytz merged 1 commit intoscala:2.13.xfrom
martijnhoekstra:b11966
May 6, 2020
Merged

Allow trailing backslash in string interpolators#8942
lrytz merged 1 commit intoscala:2.13.xfrom
martijnhoekstra:b11966

Conversation

@martijnhoekstra
Copy link
Copy Markdown
Contributor

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Apr 30, 2020
Comment thread src/library/scala/StringContext.scala
Comment thread src/library/scala/StringContext.scala
Comment thread src/library/scala/StringContext.scala
Comment thread test/files/run/literals.scala Outdated
Comment on lines +31 to +32
check_success("""s"\u0024" == "$"""", s"\u0024", "$")
check_success("s\"\"\"\\u0024\"\"\" == \"$\"", s"""\u0024""", "$")
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while coming through, do the actual naming

@SethTisue SethTisue added the prio:blocker release blocker (used only by core team, only near release time) label Apr 30, 2020
@lrytz
Copy link
Copy Markdown
Member

lrytz commented May 6, 2020

Thanks, @martijnhoekstra

@lrytz lrytz merged commit c9a8b6c into scala:2.13.x May 6, 2020
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed prio:blocker release blocker (used only by core team, only near release time) labels May 6, 2020
@SethTisue SethTisue changed the title append trailing / when processing unicode escapes Append trailing / when processing unicode escapes Jun 23, 2020
@SethTisue SethTisue changed the title Append trailing / when processing unicode escapes Append trailing / when processing unicode escapes Jun 23, 2020
@avdv
Copy link
Copy Markdown
Contributor

avdv commented Jun 26, 2020

First thought: why on earth would I want to append a trailing / while processing unicode escapes ? You meant to append a \, right? 🤓

@SethTisue SethTisue changed the title Append trailing / when processing unicode escapes Allow trailing backslash when processing unicode escapes Jun 26, 2020
@SethTisue SethTisue changed the title Allow trailing backslash when processing unicode escapes Allow trailing backslash in string interpolators Jun 26, 2020
@SethTisue
Copy link
Copy Markdown
Member

@avdv I've updated the 2.13.3 release notes as well

hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triple quoted strings and raw interpolated strings swallow trailing backslash and emit spurious warning

5 participants