Update FUNCTION LOAD changes (from release 7.0 rc3)#2973
Merged
sazzad16 merged 5 commits intoredis:masterfrom Apr 10, 2022
Avital-Fine:updateFunctionLoad
Merged
Update FUNCTION LOAD changes (from release 7.0 rc3)#2973sazzad16 merged 5 commits intoredis:masterfrom Avital-Fine:updateFunctionLoad
sazzad16 merged 5 commits intoredis:masterfrom
Avital-Fine:updateFunctionLoad
Conversation
|
This pull request introduces 1 alert when merging 453f103 into a41c7c6 - view on LGTM.com new alerts:
|
added 2 commits
April 7, 2022 17:02
|
This pull request introduces 1 alert when merging 458911c into a41c7c6 - view on LGTM.com new alerts:
|
sazzad16
reviewed
Apr 7, 2022
Contributor
sazzad16
left a comment
There was a problem hiding this comment.
@Avital-Fine Good job. Just one more issue left:
[ERROR] functionList(redis.clients.jedis.commands.jedis.ScriptingCommandsTest) Time elapsed: 0.006 s <<< FAILURE!
java.lang.AssertionError: expected:<redis.register_function('myfunc', function(keys, args) return args[1] end)> but was:<null>
at redis.clients.jedis.commands.jedis.ScriptingCommandsTest.functionList(ScriptingCommandsTest.java:378)
added 2 commits
April 8, 2022 10:34
sazzad16
approved these changes
Apr 8, 2022
zeekling
approved these changes
Apr 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis/redis#10500