Allow explicit zero width to hide outline#4334
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Feb 15, 2020
Merged
Conversation
8c110a5 to
56f30ef
Compare
Member
|
Perhaps we should mention the default change in the release notes and docstring? Or maybe it's not needed because the functionality has been fixed? |
Member
Author
|
...I'm inclined to suggest no? Documenting that we have changed the default argument would make you presume that we changed the default behaviour, which we haven't. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #4277
ImageDraw operations
chord,ellipse,piesliceandrectangletake optional argumentsoutlinewith a default ofNoneandwidthwith a default of0.At present, specifying an outline and a width of zero stills draws the outline. The following three lines all produce the same result -
This PR changes the behaviour so that a zero width produces no outline. For backwards compatibility, it changes the
widthdefault to1, so that these two lines still produce the same result -but
does not.