Remove redundant multi_line_output = 3 from "Compatibility with black"#1858
Merged
timothycrosley merged 1 commit intoPyCQA:mainfrom Nov 26, 2021
jdufresne:black-profile
Merged
Remove redundant multi_line_output = 3 from "Compatibility with black"#1858timothycrosley merged 1 commit intoPyCQA:mainfrom jdufresne:black-profile
multi_line_output = 3 from "Compatibility with black"#1858timothycrosley merged 1 commit intoPyCQA:mainfrom
jdufresne:black-profile
Conversation
According to the profiles documentation: https://pycqa.github.io/isort/docs/configuration/profiles.html The black profiles contains: "multi_line_output = 3". Avoid confusion on the "Compatibility with black" page by not adding a redundant option. The reader may believe the extra "multi_line_output" is required. This came up in a real world scenario: pypa/pyproject-hooks#137 (comment)
Codecov Report
@@ Coverage Diff @@
## main #1858 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 38 38
Lines 3046 3046
Branches 725 725
=======================================
Hits 3041 3041
Misses 1 1
Partials 4 4 |
Member
|
Thanks for fixing this! I could see how that could be confusing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the profiles documentation:
https://pycqa.github.io/isort/docs/configuration/profiles.html
The black profiles contains: "multi_line_output = 3". Avoid confusion on
the "Compatibility with black" page by not adding a redundant option.
The reader may believe the extra "multi_line_output" is required.
This came up in a real world scenario:
pypa/pyproject-hooks#137 (comment)