Merged
Conversation
Contributor
Author
|
The CI failures look like python/mypy#16480, which was a mypyc regression in mypy 1.7.0. I guess we'll have to wait for mypy 1.7.1, which will (I assume) include python/mypy#16484 (the fix to that mypy issue). |
Contributor
Author
|
Okay, for now I've changed the PR so that it only upgrades mypy to 1.6.1. That means that it no longer unblocks building mypycified wheels for Python 3.12, since mypy 1.6.1 doesn't include python/mypy@940fceb. But merging this PR will mean there will be fewer changes necessary to upgrade mypy to 1.7.1, once mypy 1.7.1 is released. |
JelleZijlstra
approved these changes
Nov 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the pinned version of mypy to 1.7.0. Since mypy 1.7.0 includes python/mypy@940fceb, this should unblock us from creating mypyc-compiled wheels for Python 3.12 (though I don't do that here; it's deferred to a followup PR).
Checklist - did you ...
CHANGES.mdif necessary?