Skip to content

Support formatting specified lines.#4020

Merged
JelleZijlstra merged 13 commits intopsf:mainfrom
yilei:ranges
Nov 7, 2023
Merged

Support formatting specified lines.#4020
JelleZijlstra merged 13 commits intopsf:mainfrom
yilei:ranges

Conversation

@yilei
Copy link
Copy Markdown
Contributor

@yilei yilei commented Nov 3, 2023

Description

This adds a command-line option --line-ranges=, to tell Black to only format these specified lines.

Fixes #830

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 3, 2023 •
edited
Loading

diff-shades reports zero changes comparing this PR (bd6d7ff) to main (ecbd9e8).

What is this? | Workflow run | diff-shades documentation

JelleZijlstra
JelleZijlstra reviewed Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, just a few pieces of minor feedback.

This has been a long-standing feature request, so it's great to finally see it in Black.

Comment thread docs/usage_and_configuration/the_basics.md Outdated
Comment thread src/black/ranges.py Outdated
Comment thread src/black/ranges.py Outdated
Comment thread src/black/ranges.py Outdated
Comment thread tests/test_ranges.py Outdated
yilei and others added 6 commits November 6, 2023 17:35
@yilei @JelleZijlstra
Update docs/usage_and_configuration/the_basics.md
6774a28 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f0c5428 
for more information, see https://pre-commit.ci
@yilei @JelleZijlstra
Update src/black/ranges.py
27cb27a 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@yilei @JelleZijlstra
Update src/black/ranges.py
78f2483 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@yilei @JelleZijlstra
Update tests/test_ranges.py
be6992e 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@yilei
Use keywords args to create _LinesMapping.
bd6d7ff
@yilei
Copy link
Copy Markdown
Contributor Author

yilei commented Nov 7, 2023

Thanks for the review! Updated.

@JelleZijlstra JelleZijlstra merged commit 46be1f8 into psf:main Nov 7, 2023
@yilei yilei deleted the ranges branch November 7, 2023 02:52
@fearedbliss
Copy link
Copy Markdown

fearedbliss commented Nov 7, 2023

Thanks for implementing this @yilei. This will be extremely useful in many situations and circumstances.

@henriholopainen
Copy link
Copy Markdown
Contributor

henriholopainen commented Nov 7, 2023

Funnily enough, I was working on the same feature and only now realised it had been finished when trying to open a draft PR. 😛 Oh well, what it's worth, my approach can be found here.

@henriholopainen
Copy link
Copy Markdown
Contributor

henriholopainen commented Nov 7, 2023

Also this PR might be enough to close this issue

@hauntsaninja hauntsaninja mentioned this pull request Nov 7, 2023
Closed
@yilei
Copy link
Copy Markdown
Contributor Author

yilei commented Nov 8, 2023

@henriholopainen Ah I'm sorry I didn't realize you were working on it. I should have sent the PR earlier as I've had it implemented for a while now.

@yilei yilei mentioned this pull request Nov 8, 2023
Closed
@skykasko skykasko mentioned this pull request Nov 8, 2023
Closed
@tartley
Copy link
Copy Markdown

tartley commented Nov 8, 2023

This option doesn't appear to be working right for me. I'll post a minimal issue...

@tartley
Copy link
Copy Markdown

tartley commented Nov 8, 2023

Minimal repro posted here: #4033

@kuator kuator mentioned this pull request Nov 26, 2023
Closed
@jvacek jvacek mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow command line option to only reformat specific lines

5 participants

@yilei @fearedbliss @henriholopainen @tartley @JelleZijlstra