Add a generation option to control use of forward declarations in headers.#9568
Merged
thomasvl merged 1 commit intoprotocolbuffers:masterfrom Mar 3, 2022
Merged
Add a generation option to control use of forward declarations in headers.#9568thomasvl merged 1 commit intoprotocolbuffers:masterfrom
thomasvl merged 1 commit intoprotocolbuffers:masterfrom
Conversation
thomasvl
commented
Mar 2, 2022
thomasvl
commented
Mar 2, 2022
Contributor
Author
|
@dmaclach fyi |
Contributor
|
Can you add me as a reviewer? I can't seem to do it for some reason... |
Contributor
Author
I think this repo/project locks down reviewers. |
dmaclach
approved these changes
Mar 3, 2022
Contributor
dmaclach
left a comment
There was a problem hiding this comment.
Approval.. all documentation nits I believe.
…ders. Swift importing ObjC drops methods/properties if the type is only a forward declaration since the type is incomplete. Historically the generator has always use forward declarations to reduce how much will have rebuild when a proto file does change; but that puts it at odds with Swift. If ObjC Protos end up spanning Swift modules, the Swift import behavior could become a problem; so this option provides a control for the behavior. The current behavior is to continue forward declarations, but eventually the default will be changed. Generate the WKTs using imports instead of forward decls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift importing ObjC drops methods/properties if the type is only a forward
declaration since the type is incomplete. Historically the generator has always
use forward declarations to reduce how much will have rebuild when a proto file
does change; but that puts it at odds with Swift. If ObjC Protos end up spanning
Swift modules, the Swift import behavior could become a problem; so this option
provides a control for the behavior. The current behavior is to continue forward
declarations, but eventually the default will be changed.
Generate the WKTs using imports instead of forward decls.