Pin multibuild scripts to get manylinux1 wheels back#9216
Pin multibuild scripts to get manylinux1 wheels back#9216haberman merged 4 commits intoprotocolbuffers:masterfrom
Conversation
| # silently creeping in. | ||
| # See https://github.com/protocolbuffers/protobuf/issues/9180 | ||
| git clone https://github.com/matthew-brett/multibuild.git | ||
| (cd multibuild; git checkout 13a01725b0f0aa551ab34aa2311cdc1c77be4337) |
There was a problem hiding this comment.
For future reference, the manylinux version can be set by setting
MB_ML_VER=1 when invoking the build_wheel. But in our case it should only be done for x86_64 artifacts (aarch64 is only supported starting from manylinux2014)
https://github.com/matthew-brett/multibuild/blob/b89bb903e94308be79abefa4f436bf123ebb1313/travis_linux_steps.sh#L71
|
Thanks Jan! It looks like the Linux Python Release job failed, perhaps because this version of multibuild doesn't support Python 3.10? |
Ok. I updated the PR:
|
Ok, I know what the problem is. It's not about multibuild version. The issue is that manylinux1 doesn't have python3.10 support (and I assume it will never have it because it's too old). So for python3.10 we will need to opt for a newer version of manylinux image (which one? manylinux2010 or manylinux2014?) |
|
@acozzette @haberman which manylinux version should we use for python3.10? We need to decide on that otherwise this PR will be stuck indefinitely. |
|
I'm not very familiar with all this but I would vote for 2014 just because 2010 sounds pretty old at this point. |
|
Can we try 2010? I think older is better here, since it increases our compatibility. |
|
2010 sounds good to me. |
ad6c7d5 to
ea60c9c
Compare
|
I updated the python3.10 wheel build to use manylinux2010. Let's see what the tests say. If they pass, I think this PR is good to go. |
The wheels built by "Linux Python Release" job look good IMHO: |
Hotfix for #9180.
See #9180 (comment) for more context.