Use byteswap.h when building against musl libc#8503
Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom Apr 16, 2021
Merged
Use byteswap.h when building against musl libc#8503acozzette merged 1 commit intoprotocolbuffers:masterfrom
acozzette merged 1 commit intoprotocolbuffers:masterfrom
Conversation
|
Thanks, @georgthegreat. |
Contributor
Author
|
Thanks, @acozzette. |
georgthegreat
added a commit
to georgthegreat/protobuf
that referenced
this pull request
Apr 19, 2021
georgthegreat
added a commit
to georgthegreat/protobuf
that referenced
this pull request
Apr 19, 2021
AlekSi
added a commit
to AlekSi/talos-tools
that referenced
this pull request
Jun 26, 2021
* https://github.com/protocolbuffers/protobuf/releases * https://github.com/protocolbuffers/protobuf-go/releases * https://github.com/grpc/grpc-go/releases Patch is not needed since protocolbuffers/protobuf#8503. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
talos-bot
pushed a commit
to siderolabs/tools
that referenced
this pull request
Jun 26, 2021
* https://github.com/protocolbuffers/protobuf/releases * https://github.com/protocolbuffers/protobuf-go/releases * https://github.com/grpc/grpc-go/releases Patch is not needed since protocolbuffers/protobuf#8503. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though manpages say bswap_ macros are GNU extensions, both bionic libc and musl libc provide them from the very first releases.
As musl intentionally does not define any specific macro, I suggest changing ifdefs to be based on operating systems rather than on libc's.