Fix unbounded memory growth for Ruby <2.7.#8429
Merged
haberman merged 4 commits intoprotocolbuffers:3.15.xfrom Mar 29, 2021
Merged
Fix unbounded memory growth for Ruby <2.7.#8429haberman merged 4 commits intoprotocolbuffers:3.15.xfrom
haberman merged 4 commits intoprotocolbuffers:3.15.xfrom
Conversation
7bbb4c4 to
e1ac393
Compare
fowles
reviewed
Mar 25, 2021
We now hold the mutex for both map insertions, to protect against a concurrent GC that removes from the seconary map before we can insert into the weak map.
fowles
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously our secondary map (needed only on Ruby <2.7) was growing without bound.
This PR adds a periodic GC pass of the secondary map to avoid this unbounded memory growth.
Fixes: #8421