Create a CMake option to control whether or not RTTI is enabled#8361
Merged
acozzette merged 1 commit intoprotocolbuffers:3.15.xfrom Mar 2, 2021
floriansimon1:allow-disabling-rtti-from-cmake-command-line-3.15.x
Merged
Create a CMake option to control whether or not RTTI is enabled#8361acozzette merged 1 commit intoprotocolbuffers:3.15.xfrom floriansimon1:allow-disabling-rtti-from-cmake-command-line-3.15.x
acozzette merged 1 commit intoprotocolbuffers:3.15.xfrom
floriansimon1:allow-disabling-rtti-from-cmake-command-line-3.15.x
Conversation
This is useful for Conan recipes that build Protobuf, in which whatever we want to enable has to be enabled in the initial command line. Without this, the people maintaining the recipe have to patch the CMake setup of Protobuf before building the binaries. Closes #5541
|
@floriansimon1 why the RTTI is now disabled by default? |
Author
|
This is a mistake. I flipped the logic incompletely. I will submit a PR to address this ASAP |
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.