Create a CMake option to control whether or not RTTI is enabled#8347
Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom Mar 2, 2021
floriansimon1:allow-disabling-rtti-from-cmake-command-line
Merged
Create a CMake option to control whether or not RTTI is enabled#8347acozzette merged 1 commit intoprotocolbuffers:masterfrom floriansimon1:allow-disabling-rtti-from-cmake-command-line
acozzette merged 1 commit intoprotocolbuffers:masterfrom
floriansimon1:allow-disabling-rtti-from-cmake-command-line
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
This is useful for Conan recipes that build Protobuf, in which whatever we want to enable has to be enabled in the initial command line. Without this, the people maintaining the recipe have to patch the CMake setup of Protobuf before building the binaries. Closes #5541
4 tasks
|
Thanks, @floriansimon1. |
Author
|
My pleasure! Do we know when the next release is planned? |
|
We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week. |
Author
|
Will do, thanks!
…-------- Message d'origine --------
Le 2 mars 2021 à 14:13, Adam Cozzette a écrit :
We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#8347 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACWAANV5IST2VGEJLFLK2EDTBU2G7ANCNFSM4YHFTSEA).
|
Author
|
@acozzette > There! #8361 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.
Closes #5541