[python-runtime] Add MethodDescriptor.CopyToProto()#8327
Merged
fowles merged 2 commits intoprotocolbuffers:masterfrom Apr 7, 2021
Merged
[python-runtime] Add MethodDescriptor.CopyToProto()#8327fowles merged 2 commits intoprotocolbuffers:masterfrom
fowles merged 2 commits intoprotocolbuffers:masterfrom
Conversation
Contributor
Author
|
Bumping this, would like to get it merged in! |
Contributor
|
Please address the Mergable failures about release note and language label |
Contributor
Author
|
@fowles thanks for taking a look. AFAIK I cannot edit the labels. |
Contributor
|
Sorry, didn't realize that you had to be in the official club to edit labels. I will do a final review on Monday. |
Contributor
|
Overall this change looks good. Can you add a test in google/protobuf/internal/descriptor_test.py? |
Contributor
Author
|
Oh, excellent---the unit test is already there, just skipped for the Python impl. I just removed the skip decorator. |
Contributor
|
Thanks! I just kicked off the CI system to test this and will try to merge this later today or early tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8326