Fix jruby support to handle messages nested more than 1 level deep#8194
Merged
acozzette merged 2 commits intoprotocolbuffers:masterfrom Jan 14, 2021
Merged
Fix jruby support to handle messages nested more than 1 level deep#8194acozzette merged 2 commits intoprotocolbuffers:masterfrom
acozzette merged 2 commits intoprotocolbuffers:masterfrom
Conversation
… and add them to the makefile
Author
|
Hey @acozzette, sorry about missing that step again. I also updated the test structure to match the other ruby tests better. |
Author
|
@acozzette are those failures something else I need to change? The details links don't give me any info. |
|
@rdubya Sorry about that, I can't see any details either. Let me rerun the tests and see if we get more informative results. If that doesn't fix it then there might be another problem because we have been having some issues with access to the test logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #8191