[objc] Use references to Obj C classes instead of names in descriptors.#7026
Merged
thomasvl merged 1 commit intoprotocolbuffers:masterfrom Jan 15, 2020
Merged
[objc] Use references to Obj C classes instead of names in descriptors.#7026thomasvl merged 1 commit intoprotocolbuffers:masterfrom
thomasvl merged 1 commit intoprotocolbuffers:masterfrom
Conversation
thomasvl
reviewed
Dec 19, 2019
thomasvl
reviewed
Dec 19, 2019
thomasvl
reviewed
Dec 20, 2019
thomasvl
approved these changes
Dec 20, 2019
dmaclach
commented
Dec 20, 2019
Contributor
Author
dmaclach
left a comment
There was a problem hiding this comment.
Merged in the changes for extensions that I had previously promised would be a separate CL. It seems to make sense to have one CL for this. It's a little larger, but keeps all the changes together if/when things break :)
thomasvl
approved these changes
Dec 20, 2019
thomasvl
reviewed
Dec 20, 2019
thomasvl
requested changes
Jan 6, 2020
Contributor
thomasvl
left a comment
There was a problem hiding this comment.
Looks like use of asm is going to cause problem, see google/google-api-objectivec-client-for-rest#322 where this just came up.
Contributor
Author
Check out latest patch. It should clear bitcode validation now as we are not declaring any new identifiers. |
thomasvl
requested changes
Jan 10, 2020
145e97d to
7adc675
Compare
thomasvl
approved these changes
Jan 10, 2020
…y name. This should reduce binary size slightly, small performance improvement, and improve linkage by forcing references to all used classes. Note that this maintains backwards compatibility for sources generated by older protoc for the time being. If you want the benefits you will need to recompile your protos with the newer protoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the compiler and library to use objective-c class references instead of class names (that are resolved using objc_getClass/NSClassFromString).
This should: